Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load addresses based on netId #25

Merged
merged 2 commits into from
Dec 30, 2017
Merged

load addresses based on netId #25

merged 2 commits into from
Dec 30, 2017

Conversation

rstormsf
Copy link
Contributor

No description provided.

@igorbarinov
Copy link
Member

@rstormsf Let's follow PR police we have in Wizard in other DApps https://github.com/poanetwork/ico-wizard/wiki/Pull-Request-Policy

Quote:

- (Mandatory) Description
   a human-readable description of changes
   a human-readable description of the purpose of the PR
- (Mandatory) What is it: (Fix), (Feature), or (Refactor) in Title, e.g., "(Fix) price of 1 token in Wei > 18 decimals"
- (Mandatory) Developers: Each completed PR should be updated in the Wiki Documentation.
(Recommended) Each PR should have one commit message and therefore should only contain one specific fix or feature. Otherwise, multiple PRs should be made
- (Optional) Any additional concerns or comments

vbaranov
vbaranov reviewed Dec 30, 2017
View reviewed changes
src/contracts/addresses.js Outdated
KEYS_MANAGER_ADDRESS: '0xfc90125492e58dbfe80c0bfb6a2a759c4f703ca8',
POA_ADDRESS: '0x8bf38d4764929064f2d4d3a56520a76ab3df415b',
MOC: '0xCf260eA317555637C55F70e55dbA8D5ad8414Cb0'
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion here: core addresses are written twice. Let's create const:

const CORE_ADDRESSES = {
    METADATA_ADDRESS: '0xcBB2912666c7e8023B7ec78B6842702eB26336aC',
    KEYS_MANAGER_ADDRESS: '0xfc90125492e58dbfe80c0bfb6a2a759c4f703ca8',
    POA_ADDRESS: '0x8bf38d4764929064f2d4d3a56520a76ab3df415b',
    MOC: '0xCf260eA317555637C55F70e55dbA8D5ad8414Cb0'
 }

to use it as a default and for core network in switch. Other updates look good for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will do

@igorbarinov
Copy link
Member

Summarized out PR Policy for DApps in RFC (new format of sharing common policies)
Please comment poanetwork/RFC#3
@vbaranov @rstormsf

Btw, @rstormsf let's create an RFC about core/sokol branches modification and policy for all our DApps

@rstormsf rstormsf merged commit 2681a87 into poanetwork:core Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbaranov vbaranov vbaranov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rstormsf @igorbarinov @vbaranov